Fixes for recent Julia versions #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base.catch_stack() was deprecated in 1.7.
In v1.9, Base.cumulative_compile_time_ns() was changed to return a tuple of `(compile_time, recompile_time)`. We now use the sum of the two to show the total compilation time.
JamesWrigley
force-pushed
the
latest-fixes
branch
from
6c7dcbb
to
b6c073a
Compare
Merged
|
(gentle bump) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has two fixes for issues I came across on 1.10:
Base.catch_stack()on >= 1.7 (1f5d44a)Base.cumulative_compile_time_ns()on >= 1.9 (6c7dcbb). Without this the tests would hang whenstats=truewas passed becauseprint_test_results()would fail, which caused theprintertask to fail, which meant that there would be no readerstake!()'ing from the workeroutchan, which caused everything to hang.Fixes #49.