Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for recent Julia versions #54

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

JamesWrigley
Copy link
Member

This has two fixes for issues I came across on 1.10:

  • Stop using the deprecated Base.catch_stack() on >= 1.7 (1f5d44a)
  • Update the use of Base.cumulative_compile_time_ns() on >= 1.9 (6c7dcbb). Without this the tests would hang when stats=true was passed because print_test_results() would fail, which caused the printer task to fail, which meant that there would be no readers take!()'ing from the worker outchan, which caused everything to hang.

Fixes #49.

Base.catch_stack() was deprecated in 1.7.
In v1.9, Base.cumulative_compile_time_ns() was changed to return a tuple of
`(compile_time, recompile_time)`. We now use the sum of the two to show the
total compilation time.
@JamesWrigley
Copy link
Member Author

(gentle bump)

Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JamesWrigley JamesWrigley merged commit 351d0d8 into JuliaTesting:master Sep 9, 2024
12 checks passed
@JamesWrigley JamesWrigley deleted the latest-fixes branch September 9, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation of catch_stack causes slowdown
2 participants